-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop unsupported locales from moment #42521
Open
uladzimirdev
wants to merge
1
commit into
master
Choose a base branch
from
shake-moment
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codenotify: Notifying subscribers in CODENOTIFY files for diff eca348e...3704ca9.
|
uladzimirdev
force-pushed
the
shake-moment
branch
from
May 13, 2024 06:57
0044cb0
to
3704ca9
Compare
uladzimirdev
changed the title
Drop unused locales from moment
Drop unsupported locales from moment
May 13, 2024
alxnddr
approved these changes
May 15, 2024
alxnddr
reviewed
May 16, 2024
// https://www.metabase.com/docs/latest/configuring-metabase/localization | ||
new MomentLocalesPlugin({ | ||
localesToKeep: [ | ||
"sq", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
no-backport
Do not backport this PR to any branch
.Team/QueryingComponents
visual
Run Percy visual testing
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #42552
Description
moment includes all locales by default, increasing bundle size, but we don't need some of them
How to verify
verify the list of supported locales and try to change locale in admin settings
Demo
Before
After